[Buildroot] [PATCH v2] package/mfgtools: Allow target build

[Thomas Petazzoni]

Hello Vincent,

On Mon, 14 May 2018 11:11:14 +0200
Vincent Prince <vincent.prince.fr at gmail.com> wrote:

> Signed-off-by: Vincent Prince <vincent.prince.fr at gmail.com>

Sorry for the very long delay in answering. First of all, the 0.02
version of mfgtools we're using is very, very old. Upstream has much
more recent version, which hopefully cross-compile better. It would
probably be beneficial to start by updating to a more recent version.

> diff --git a/package/mfgtools/0001-Fix-CXXFLAGS-in-CMakeList.patch b/package/mfgtools/0001-Fix-CXXFLAGS-in-CMakeList.patch
> new file mode 100644
> index 0000000..eee58b8
> --- /dev/null
> +++ b/package/mfgtools/0001-Fix-CXXFLAGS-in-CMakeList.patch
> @@ -0,0 +1,62 @@
> +CMakeLists.txt: Fix cross-compilation

This is way too short. What gets fixed already ? The patch file name
mentions just fixing CXXFLAGS, but the patch does much more.

Also, since upstream uses Git, we want a patch generated by "git
format-patch". But as said above, perhaps updating to a newer upstream
release will help avoid these cross-compilation issues.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com