[Buildroot] [PATCH] Revert "package/gettext-tiny: bump version to add --template option"

Vadim Kochan vadim4j at gmail.com
Sun Apr 7 08:03:55 UTC 2019


Hi Yann, All

On Sun, Apr 07, 2019 at 09:37:08AM +0200, Yann E. MORIN wrote:
> This reverts commit 758ea0e518492c703482a323653c3d20520b599b.
> 
> 758ea0e bumped gettext-tiny to the latest (at the time) head of the
> upstream git tree. In so doing, it included an upstream change of
> behaviour that eventually broke the build of packages that use
> -Werror=format-string.
> 
> Even though in Buildroot we usually try to avoid building with -Werror,
> it is sometimes hard to go against such flags, especially when the
> package uses an expicit, long list of such -Werror=foo flags.
> 
> Revert the bump.
> 
> Fixes:
>     http://autobuild.buildroot.org/results/dec/decbbcad11fbf312f6e5fbe0bf32143bedb6610b/
>     [and many more...]
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Giulio Benetti <giulio.benetti at micronovasrl.com>
> Cc: Vadim Kochan <vadim4j at gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Cc: Peter Korsgaard <peter at korsgaard.com>
> ---
>  package/gettext-tiny/gettext-tiny.hash | 2 +-
>  package/gettext-tiny/gettext-tiny.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/gettext-tiny/gettext-tiny.hash b/package/gettext-tiny/gettext-tiny.hash
> index 7d13054144..672e964186 100644
> --- a/package/gettext-tiny/gettext-tiny.hash
> +++ b/package/gettext-tiny/gettext-tiny.hash
> @@ -1,5 +1,5 @@
>  # Locally Computed:
> -sha256 00b03b08d909021aa5580fb45b6cf0ec45e9084ef94c26f034f03a64a69942bc  gettext-tiny-c6dcdcdef801127549d3906d153c061880d25a73.tar.gz
> +sha256 654dcd52f2650476c8822b60bee89c20a0aa7f6a1bf6001701eeacd71a9e388b  gettext-tiny-v0.3.1.tar.gz
>  sha256 b57aa4fdc1c614c28d41c1e2d5c4090935964c5f86291ba7d1c99ffd1d698b34  LICENSE
>  sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903  extra/COPYING
>  # From http://lists.gnu.org/archive/html/bug-gettext/2016-06/msg00008.html
> diff --git a/package/gettext-tiny/gettext-tiny.mk b/package/gettext-tiny/gettext-tiny.mk
> index e3a6d11399..881edc6f35 100644
> --- a/package/gettext-tiny/gettext-tiny.mk
> +++ b/package/gettext-tiny/gettext-tiny.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -GETTEXT_TINY_VERSION = c6dcdcdef801127549d3906d153c061880d25a73
> +GETTEXT_TINY_VERSION = v0.3.1
>  GETTEXT_TINY_SITE = $(call github,sabotage-linux,gettext-tiny,$(GETTEXT_TINY_VERSION))
>  GETTEXT_TINY_LICENSE = MIT, GPL-3.0+ (extra gettext)
>  GETTEXT_TINY_INSTALL_STAGING = YES

I am testing a fix with passing LIBINTL=NONE in gettext-tiny.mk which
does not install libintl.h at all, I think this should be ok as each
kind of toolchain should provide gettext stubs already.

Regards,
Vadim Kochan



More information about the buildroot mailing list