[Buildroot] [PATCH] gettext-tiny: Make libiconv only target dependency

[Thomas Petazzoni]

Hello,

On Mon,  8 Apr 2019 17:04:42 +0300
Alexey Brodkin <alexey.brodkin at synopsys.com> wrote:

> diff --git a/package/gettext-tiny/gettext-tiny.mk b/package/gettext-tiny/gettext-tiny.mk
> index 4fa014e8dd..f07903d203 100644
> --- a/package/gettext-tiny/gettext-tiny.mk
> +++ b/package/gettext-tiny/gettext-tiny.mk
> @@ -50,7 +50,7 @@ endef
>  HOST_GETTEXT_TINY_POST_PATCH_HOOKS += HOST_GETTEXT_TINY_COPY_EXTRA_FILES
>  
>  ifeq ($(BR2_ENABLE_LOCALE),)
> -HOST_GETTEXT_TINY_DEPENDENCIES = libiconv
> +GETTEXT_TINY_DEPENDENCIES = libiconv
>  endif

Hm, the issue I see is that gettext-tiny/Config.in does not select
BR2_PACKAGE_LIBICONV, so we would run into the error that libiconv is
used as a dependency but not selected.

While looking at this, I realize that gettext-gnu does have the
conditional dependency on libiconv, but does not select it. libiconv
seems to no longer be needed since commit
187b4d68e0ad9e92492345c5863da40e32863eda, but we forgot to remove the
libiconv conditional dependency in gettext-gnu.mk.

Vadim, do you confirm ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com