[Buildroot] [PATCH 2/3] package/mosquitto: Switch systemd unit to Type=notify and depend on network
Peter Korsgaard
peter at korsgaard.com
Thu Aug 1 10:27:22 UTC 2019
>>>>> "Titouan" == Titouan Christophe <titouan.christophe at railnova.eu> writes:
> Signed-off-by: Titouan Christophe <titouan.christophe at railnova.eu>
It would be great if your commit message would explain _WHY_ this is
done, not just _WHAT_ the change is - E.G. what is the advantage of type=notify?
> ---
> RFC: Would it be better to use the mosquitto.service file provided upstream ?
> https://github.com/eclipse/mosquitto/blob/master/service/systemd/mosquitto.service.notify
Not knowing much about systemd, but I think so. The differences look
quite small.
> ---
> package/mosquitto/mosquitto.mk | 4 ++++
> package/mosquitto/mosquitto.service | 3 +++
> 2 files changed, 7 insertions(+)
> diff --git a/package/mosquitto/mosquitto.mk b/package/mosquitto/mosquitto.mk
> index ed72af754a..333cce35c2 100644
> --- a/package/mosquitto/mosquitto.mk
> +++ b/package/mosquitto/mosquitto.mk
> @@ -23,6 +23,10 @@ else
> MOSQUITTO_MAKE_OPTS += WITH_STATIC_LIBRARIES=no WITH_SHARED_LIBRARIES=yes
> endif
> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> +MOSQUITTO_MAKE_OPTS += WITH_SYSTEMD=yes
This is not mentioned in the commit message. I see this causes mosquitto
to link with -lsystemd, so you need to add systemd to
MOSQUITTO_DEPENDENCIES.
Care to send an updated patch with a more descriptive commit message,
reusing the upstream service file and adding systemd to _DEPENDENCIES?
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list