[Buildroot] [PATCH 04/13 v2] core: rename generated .br-external.mk file

Peter Korsgaard peter at korsgaard.com
Sat Aug 3 19:48:11 UTC 2019


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

 > Now that the two (all of them!) br2-external related files are generated
 > in the same location, it makes sense they are named after the same
 > pattern.

 > When initial support for (then single) br2-external trees was added back
 > in a4239f7fd1 (core: introduce the BR2_EXTERNAL variable), it was not
 > clear-cut why that file was not named with a br2 prefix.

 > So rename it now.

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
 > Cc: Vadim Kochan <vadim4j at gmail.com>

 > ---
 > Changes v1 -> v2:
 >   - update manual accordingly

 > ---
 > The reason for the original naming is probably because of the long
 > undocumented (except buried in an old dev-days report) and mostly
 > never-obeyed rule that internal variables should be prefixed with
 > BR_ not BR2_, the latter being reserved for user-facing variables,
 > and thus the same was thought for the generated file. Or maybe not...

Possibly ;)

Committed, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list