[Buildroot] [PATCH] package/restclient-cpp: new package

Gilles Talis gilles.talis at gmail.com
Wed Aug 7 07:12:05 UTC 2019


Hello Adam,

Thanks for your review.

Le mer. 7 août 2019 à 00:16, Adam Duskett <aduskett at gmail.com> a écrit :
>
> Hi Gilles;
>
> On Sun, Aug 4, 2019 at 12:44 PM Gilles Talis <gilles.talis at gmail.com> wrote:
> >
> Generally there's a description of what the package is/does at the
> beginning of a patch.
OK. Will add this.


> > +RESTCLIENT_CPP_VERSION = 0.5.1
> > +RESTCLIENT_CPP_SOURCE = $(RESTCLIENT_CPP_VERSION).tar.gz
> > +RESTCLIENT_CPP_SITE = https://github.com/mrtazz/restclient-cpp/archive
> Please use the github macro:
> $(call github,mrtazz,restclient-cpp,$(RESTCLIENT_CPP_VERSION))
You're right. Following your comment, I re-read the user manual, and
it makes better sense now :-)

I will send a v2 shortly.
Regards
Gilles.



More information about the buildroot mailing list