[Buildroot] [PATCH v4 00/13] use host-systemd to enable units

Thomas Petazzoni thomas.petazzoni at bootlin.com
Thu Dec 12 10:14:38 UTC 2019


Hello Jérémy,

I have a very minor comment, no need to resend just for that: I'd like
the commit titles to be a bit nicer. See below for some suggestions.

On Thu, 12 Dec 2019 08:53:47 +0100
Jérémy Rosen <jeremy.rosen at smile.fr> wrote:

> Jérémy Rosen (13):
>   new recipe : host-systemd

Should be:

	package/systemd: add host variant

>   use host-systemctl preset all to enable units

	package/systemd: use host-systemctl preset-all to enable units

>   fix tty handling

	package/systemd: fix tty handling

>   fix trivial packages with buildroot-provided services

	package: rely on systemctl preset-all for buildroot-provided services

>   fix trivial cases, upstream-provided services

	package: rely on systemctl preset-all for upstream-provided services

>   package/connman: adapt to preset-all

	package/commman: adapt to systemctl preset-all

>   package/linuxptp adapt to preset-all
>   package/network-manager: adapt to preset-all
>   package/wpa_supplicant: adapt for preset-all

Ditto for those ones.

>   package/sysrepo: update to new systemd
>   package/syslog-ng: implement default using DefaultInstance
>   package/rauc: add a WantedBy section to the unit
>   package/alsa-utils: add a WantedBy section to the unit

In those last three ones, perhaps have "systemd" somewhere in the
commit title.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list