[Buildroot] [git commit] package/genimage: add patch to support vfat volume-label

Peter Korsgaard peter at korsgaard.com
Sun Dec 22 20:25:38 UTC 2019


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:

 > On Sun, 22 Dec 2019 16:01:26 +0100
 > Peter Korsgaard <peter at korsgaard.com> wrote:

 >> > Import "0001-image-vfat-Add-label-option-to-set-volume-name.patch" from
 >> > the upstream repository. The changes made to the README.rst file had to
 >> > be removed from the patch so that the package can be compiled in
 >> > buildroot. The patch has been accepted upstream, but no releases have
 >> > been made yet which includes the feature.  
 >> 
 >> > Signed-off-by: Dario Binacchi <dariobin at libero.it>
 >> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>  
 >> 
 >> Why? What is this required for? When is the next genimage version expected?

 > Well, it's just a new feature that someone needs. We normally don't
 > take feature patches, but this one is a backport from upstream.
 > genimage also does new releases fairly infrequently, so waiting for the
 > next release is not necessarily nice. The patch was short enough, taken
 > directly from upstream, so I said "ok, let's take, it will anyway go
 > away the next time we bump".

OK, but we indeed don't take feature patches unless there is a good
reason for it, and this commit is just syntactical sugar over adding -n
<label> to extraargs, E.G.:

image foo.fat {
  vfat {
    extraargs = "-n MYLABEL"
    ..
}

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list