[Buildroot] [PATCH v4 16/17] package/fftw: remove as regular package
Yann E. MORIN
yann.morin.1998 at free.fr
Sat Feb 2 17:16:41 UTC 2019
Gwenhael, All,
On 2019-01-21 14:51 +0100, Gwenhael Goavec-Merou spake thusly:
> From: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
>
> From: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
>
> fftw is no longer a package: only fftw-single, fftw-double,
> fftw-long-double and fftw-quad are. fftw.mk only contains some common
> definitions that are used by the different fftw variants.
>
> The old BR2_PACKAGE_FFTW_PRECISION_* options, which are no longer used
> anywhere, are moved to Config.in.legacy.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou at trabucayre.com>
> ---
> Changes v3 -> V4:
> * when BR2_PACKAGE_FFTW is enabled without flavour, selects fftw-double
> by default. (Yann)
> * suppress suppress two consecutive empty lines. (Yann)
:-)
[--SNIP--]
> diff --git a/package/fftw/fftw.mk b/package/fftw/fftw.mk
> index 862ad5edc0..bcfdb9c96a 100644
> --- a/package/fftw/fftw.mk
> +++ b/package/fftw/fftw.mk
> @@ -10,22 +10,6 @@ FFTW_INSTALL_STAGING = YES
> FFTW_LICENSE = GPL-2.0+
> FFTW_LICENSE_FILES = COPYING
>
> -ifeq ($(BR2_PACKAGE_FFTW_DOUBLE),y)
> -FFTW_DEPENDENCIES += fftw-double
> -endif
> -
> -ifeq ($(BR2_PACKAGE_FFTW_LONG_DOUBLE),y)
> -FFTW_DEPENDENCIES += fftw-long-double
> -endif
> -
> -ifeq ($(BR2_PACKAGE_FFTW_QUAD),y)
> -FFTW_DEPENDENCIES += fftw-quad
> -endif
> -
> -ifeq ($(BR2_PACKAGE_FFTW_SINGLE),y)
> -FFTW_DEPENDENCIES += fftw-single
> -endif
Actually, I think these dependencies should stay. This would allow a
package that needs any fftw variant to just select BR2_PACKAGE_FFTW
and add FOO_DEPENDENCIES = fftw.
Regards,
Yann E. MORIN.
> # fortran support only enables generation and installation of fortran sources
> ifeq ($(BR2_TOOLCHAIN_HAS_FORTRAN),y)
> FFTW_COMMON_CONF_OPTS += --enable-fortran
> @@ -49,6 +33,4 @@ FFTW_COMMON_CONF_OPTS += --disable-threads
> endif
> FFTW_COMMON_CONF_OPTS += $(if $(BR2_GCC_ENABLE_OPENMP),--enable,--disable)-openmp
>
> -$(eval $(generic-package))
> -
> include $(sort $(wildcard package/fftw/*/*.mk))
> --
> 2.19.2
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list