[Buildroot] [PATCH 1/3] support/testing: test_dropbear.py: use a constant for the password
Peter Korsgaard
peter at korsgaard.com
Tue Feb 5 09:45:40 UTC 2019
The password is used in multiple places, so add a constant for it instead of
hardcoding it multiple times.
Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
---
support/testing/tests/package/test_dropbear.py | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/support/testing/tests/package/test_dropbear.py b/support/testing/tests/package/test_dropbear.py
index 8f7f1fee82..2a7a1bd8af 100644
--- a/support/testing/tests/package/test_dropbear.py
+++ b/support/testing/tests/package/test_dropbear.py
@@ -4,14 +4,15 @@ import infra.basetest
class TestDropbear(infra.basetest.BRTest):
+ passwd = "testpwd"
config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
"""
- BR2_TARGET_GENERIC_ROOT_PASSWD="testpwd"
+ BR2_TARGET_GENERIC_ROOT_PASSWD="{}"
BR2_SYSTEM_DHCP="eth0"
BR2_PACKAGE_DROPBEAR=y
BR2_TARGET_ROOTFS_CPIO=y
# BR2_TARGET_ROOTFS_TAR is not set
- """
+ """.format(passwd)
def test_run(self):
img = os.path.join(self.builddir, "images", "rootfs.cpio")
@@ -20,7 +21,7 @@ class TestDropbear(infra.basetest.BRTest):
options=["-initrd", img,
"-net", "nic",
"-net", "user,hostfwd=tcp::2222-:22"])
- self.emulator.login("testpwd")
+ self.emulator.login(self.passwd)
cmd = "netstat -ltn 2>/dev/null | grep 0.0.0.0:22"
_, exit_code = self.emulator.run(cmd)
self.assertEqual(exit_code, 0)
--
2.11.0
More information about the buildroot
mailing list