[Buildroot] [PATCH v7 7/8] package/rtmpdump: Fix compilation issues with openssl 1.1.x

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:

 > On 04/02/2019 11:06, Peter Korsgaard wrote:
 >>>>>>> "Patrick" == Patrick Havelange <patrick.havelange at essensium.com> writes:
 >> 
 >> > From: Vadim Kochan <vadim4j at gmail.com>
 >> > Upstream is dead, other distros use gnutls exclusively,
 >> > so patch is not sent upstream.
 >> 
 >> So shouldn't we do the same?
 >> 
 >> What other distributions exactly?

 >  IIRC I checked at least Fedora and Debian, possibly also Gentoo and/or Arch.

Ok, which probably makes sense for a binary distribution.

It is not exactly clear to me where this patch comes from. Googling
around I see a very similar patch on this github repo:

https://github.com/JudgeZarbi/RTMPDump-OpenSSL-1.1

But that repo has an open issue about a crash in the handshake handling
(code that gets changed by this patch) and the README states:

I modified a few of the files in the librtmp directory to conform to the
new getters and setters in OpenSSL 1.1.0. I don't claim to be a security
expert, and neither have I had any experience with OpenSSL in a
programming sense, so I'm not sure exactly if it's correct, but it
compiles and seems to work for what I use it for.

Which does not sound very reassuring to me, so I have instead pushed a
patch to drop the openssl support for rtmpdump.

-- 
Bye, Peter Korsgaard