[Buildroot] [PATCH] add library xmlsec1

Bastian Breit bastian.breit.buildroot at gmail.com
Sun Feb 10 14:12:48 UTC 2019


Hello Thomas,

> > +LIBXMLSEC1_CONF_OPTS += --with-libxslt=no
>
> Why ? You have a dependency on libxslt. Also, if this dependency is not
> mandatory, it should be made optional.
>
> > +LIBXMLSEC1_CONF_OPTS += --with-gnutls=no
> > +LIBXMLSEC1_CONF_OPTS += --with-gcrypt=no
>
> So OpenSSL is not mandatory and GnuTLS or GCrypt could be used ? If
> that is the case, then it should be supported.
>
> > +LIBXMLSEC1_DEPENDENCIES = libxml2 libxslt openssl
> > +
> > +$(eval $(autotools-package))
>
> Could you rework your package to address those comments ?
>
> Thanks a lot!

I locally fixed the formatting and licence part.
I had some trouble with the mailing list and will use
bastian.breit.buildroot at gmail.com from now on. We use libxmlsec1 in
this context and haven't used another configuration. I am not sure,
how the library works in other configuration. I would create config
options for each option based on that list at
https://www.aleksey.com/xmlsec/faq.html
Should I send changes for formatting & licences with a different patch
or should I send an all in one patch?

Sincerely

Bastian



More information about the buildroot mailing list