[Buildroot] [PATCH RFC/next 1/4] package/webkit: new home for GTK and WPE WebKit components

[François Perrad]

Le ven. 22 févr. 2019 à 15:47, Adrian Perez de Castro <aperez at igalia.com> a
écrit :

> Hello!
>
> On Fri, 22 Feb 2019 11:40:20 +0100, François Perrad <
> francois.perrad at gadz.org> wrote:
> > Le lun. 18 févr. 2019 à 18:17, Adrian Perez de Castro <aperez at igalia.com>
> a
> > écrit :
> >
> > > Move the packages related to the GTK and WPE WebKit ports (webkitgtk,
> > > libwpe, wpewebkit, wpebackend-fdo) under a new package/webkit/
> > > subbdirectory as the first step to unify some of their configuration.
> > >
> > >
> > Moving packages into a subdirectory is discouraged,
> > see
> https://buildroot.org/downloads/manual/manual.html#_package_directory
>
> On the other hand, while adding new subdirectories is discouraged, it is
> not forbidden. In this case I thought that it could make sense grouping the
> the (very related) WebKit packages. Also note that I expect to be adding a
> more in the future [1].
>
> That being said, I am of course open to alternative suggestions, and in
> particular knowing where the common parts that this patch set adds into
> “webkit/webkit.mk” and “webkit/Config.in” would go in the case of not
> making a subdirectory to group the related packages. Any ideas?
>
> Cheers,
>
>
> -Adrián
>
>
> > François
> >
>
> Le ven. 22 févr. 2019 à 15:47, Adrian Perez de Castro <aperez at igalia.com>
> a écrit :
> Hello!
>
> On Fri, 22 Feb 2019 11:40:20 +0100, François Perrad <
> francois.perrad at gadz.org> wrote:
> > Le lun. 18 févr. 2019 à 18:17, Adrian Perez de Castro <aperez at igalia.com>
> a
> > écrit :
> >
> > > Move the packages related to the GTK and WPE WebKit ports (webkitgtk,
> > > libwpe, wpewebkit, wpebackend-fdo) under a new package/webkit/
> > > subbdirectory as the first step to unify some of their configuration.
> > >
> > >
> > Moving packages into a subdirectory is discouraged,
> > see
> https://buildroot.org/downloads/manual/manual.html#_package_directory
>
> On the other hand, while adding new subdirectories is discouraged, it is
> not forbidden. In this case I thought that it could make sense grouping the
> the (very related) WebKit packages. Also note that I expect to be adding a
> more in the future [1].
>
> That being said, I am of course open to alternative suggestions, and in
> particular knowing where the common parts that this patch set adds into
> “webkit/webkit.mk” and “webkit/Config.in” would go in the case of not
> making a subdirectory to group the related packages. Any ideas?
>
>
You could create a virtual package webkit with 2 providers webkitgtk &
wpewebkit.
See details on
https://buildroot.org/downloads/manual/manual.html#virtual-package-tutorial

midori still depends on webkitgtk,
but cog could depends on webkit, ie. using webkitgtk or wpewebkit.

François



> Cheers,
>
>
> -Adrián
>
>
> > François
> >
> >
> > > Signed-off-by: Adrian Perez de Castro <aperez at igalia.com>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190222/63a4c315/attachment-0002.html>