[Buildroot] [PATCH] make printvars: avoid invalid calls when arguments are missing

[Thomas Petazzoni]

Hello Martin,

On Sat, 23 Feb 2019 17:11:08 +0100
Martin Kepplinger <martin.kepplinger at ginzinger.com> wrote:

> diff --git a/package/Makefile.in b/package/Makefile.in
> index dc818a2c18..f4f3864e8d 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -232,6 +232,7 @@ HOST_LDFLAGS  += -L$(HOST_DIR)/lib -Wl,-rpath,$(HOST_DIR)/lib
>  # Usage: option = $(call try-run, $(CC)...-o "$$TMP",option-ok,otherwise)
>  # Exit code chooses option. "$$TMP" is can be used as temporary file and
>  # is automatically cleaned up.
> +ifneq ($(1),)

$(1) only makes sense inside the macro itself. Outside the macro $(1)
does not make sense at all, and will always be empty I believe. Are you
sure your patch is working, and does not break the build ?

Indeed, I believe the two macros you enclose in ifneq tests will in
fact no longer be defined.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com