[Buildroot] [PATCH next 1/1] package/libwebsockets: bump version to 3.1.0

Thomas Petazzoni thomas.petazzoni at bootlin.com
Mon Feb 25 21:20:58 UTC 2019


Hello Adam,

On Sat, 23 Feb 2019 15:17:36 -0500
aduskett at gmail.com wrote:

> +-if (LWS_WITH_LIBEV AND LWS_WITH_LIBEVENT)
> +-	message(FATAL_ERROR "Sorry libev and libevent conflict with each others' namespace, you can only have one or the other")
> +-endif()

I'm a bit confused by this patch. Why are removing this check ? If
libwebsockets is anyway only using libev *or* libevent, what about
changing libwebsockets.mk to only allow using one or the other ?

This is the only point I've seen, the rest looks good to me.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list