[Buildroot] [PATCH 06/19] infra/pkg-generic: only list files installed by the current package

Yann E. MORIN yann.morin.1998 at free.fr
Tue Jan 8 19:51:47 UTC 2019


Thomas DS, All,

On 2019-01-08 16:56 +0100, Thomas De Schampheleire spake thusly:
> El mar., 8 ene. 2019 a las 14:07, Thomas De Schampheleire
> (<patrickdepinguin at gmail.com>) escribió:
[--SNIP--]
> > > -               -newer $($(PKG)_DIR)/.stamp_built \
> > > +               -newer $@_before \
> > While it is probably not important, just noting here that if package A
> > installs a file with a modification time in the future, then package B
> > installed after A would still get that future file in its list. In
> > fact, every package built after pkg A would then get that file into
> > 'its' list.
> Possibly more realistically, a package installing a file with a fixed
> timestamp in the past, perhaps a timestamp of the build time preserved
> via 'cp -a'.

Actually, we already have this very issue with our skeleton: its files
are copied and their timestamps are kept as-is, so the files are almost
certainly older than the built timestamp, and thus are not accounted for
againt the skeleton.

I already identified this problem a few days ago while working on this
series, and I had considered fixing it later, or the series would get
even bigger...

And yes, the problem already happens with the current situation.

If we wanted to be exhaustive, we'd also list files that are not already
in the list (and warn loudly). And since we introduce a new format, we
could more easily add a "metadata" field that specifies why the entry
was added (mtime, new-but-old, etc...)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list