[Buildroot] [External] Re: [PATCH 1/1] fs/common.mk: enable multithreaded xz compression

Matthew Weber matthew.weber at collins.com
Mon Jan 21 14:28:46 UTC 2019


On Mon, Jan 21, 2019 at 8:05 AM James Hilliard
<james.hilliard1 at gmail.com> wrote:
>
> On Mon, Jan 21, 2019 at 7:02 AM Matthew Weber <matthew.weber at collins.com> wrote:
> >
> > James,
> >
> >
> > On Sun, Jan 20, 2019 at 8:08 PM <james.hilliard1 at gmail.com> wrote:
> > >
> > > From: James Hilliard <james.hilliard1 at gmail.com>
> > >
> > > xz help indicates only 1 thread is used unless we set threads:
> > > -T, --threads=NUM   use at most NUM threads; the default is 1; set to 0
> > >                     to use as many threads as there are processor cores
> > >
> >
> > It's good to see xz now has support, but I assume there is a minimum
> > version?  We ran into this outside of Builroot on a project where we
> > conditionally used the parallel "pxz" tool when available, as "xz"
> > didn't have the -T support consistently in distros yet.
> I thought it was using the version compiled by buildroot.
> Isn't that what host-xz is being used for?

Ah, true.  I had glanced at the dependency checking scripts but we
always built it based on the fs/common.mk dependency on host-xz so
that is correct.

One other comment would be that "0" wouldn't be ideal on a shared
machine.  Suggest limiting to $(PARALLEL_JOBS) which is used in other
filesystem creation (grep fs folder for an example in iso9660 or
squashfs).

Reviewed-by: Matthew Weber <matthew.weber at rockwellcollins.com>



More information about the buildroot mailing list