[Buildroot] [PATCH 2/8] package/sdl_sound: actually use the optional CONF_OPTS

Peter Korsgaard peter at korsgaard.com
Tue Jan 29 21:57:46 UTC 2019


>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski at gmail.com> writes:

 > Since "57ace26b6c package/sdl_sound: add optional support for
 > libmodplug" from 2016, optional CONF_OPTS are added but they do not
 > really take effect because there is an unconditional override below the
 > conditional append.

 > Currently this does not cause build failures, but it can lead to wrong
 > detection of dependencies because many explicit --enable/--disable are
 > not passed to configure.

 > Fix this by moving the unconditional code to the top.

 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski at gmail.com>

Committed to 2018.02.x and 2018.11.x, thanks.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list