[Buildroot] [PATCH] package/docker-engine: add sysv init script
Peter Korsgaard
peter at korsgaard.com
Thu Jan 31 07:32:04 UTC 2019
>>>>> "Christian" == Christian Stewart <christian at paral.in> writes:
> Hi Peter,
> Peter Korsgaard <peter at korsgaard.com> writes:
>> +++ b/package/docker-engine/S60dockerd
>> @@ -0,0 +1,38 @@
>> +#!/bin/sh
>> +
>> +NAME=dockerd
>> +DAEMON=/usr/bin/$NAME
>> +PIDFILE=/var/run/$NAME.pid
>> +DAEMON_ARGS=""
> We pull the systemd unit file from /contrib/init/systemd/docker.service
> within the docker-engine codebase.
> There also exists /contrib/init/openrc as well as sysvinit-debian,
> sysvinit-redhat, and upstart. I guess none of these are suitable for the
> sysv init system.
Yes, but those all look very complicated and/or does more than we want,
E.G. handling the croupfs mounts which we do in S30cgroupfs.
>> +define DOCKER_ENGINE_INSTALL_INIT_SYSV
>> + $(INSTALL) -D -m 755 package/docker-engine/S60dockerd \
>> + $(TARGET_DIR)/etc/init.d/S60dockerd
>> +endef
> In general LGTM.
> Acked-by: Christian Stewart <christian at paral.in>
Thanks.
Committed, thanks.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list