[Buildroot] [git commit branch/2019.05.x] package/pkg-golang: do not set static linking for host target

Peter Korsgaard peter at korsgaard.com
Sun Jun 23 20:20:20 UTC 2019


commit: https://git.buildroot.net/buildroot/commit/?id=e29d015b350d036fd6f1678b2462a1420122b15f
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/2019.05.x

The current logic will set the "-static" flag when building go
host packages if BR2_STATIC_LIBS is set, this will not work as
there is no support to link host packages statically.

Fix this by applying this logic only for target builds.

Signed-off-by: Mirza Krak <mirza.krak at northern.tech>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
(cherry picked from commit 60d455f20b9c656c2a23ce4e8dc03719e55f7453)
Signed-off-by: Peter Korsgaard <peter at korsgaard.com>
---
 package/pkg-golang.mk | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/package/pkg-golang.mk b/package/pkg-golang.mk
index 72e8f6b7af..e47de17aba 100644
--- a/package/pkg-golang.mk
+++ b/package/pkg-golang.mk
@@ -58,10 +58,6 @@ define inner-golang-package
 
 $(2)_WORKSPACE ?= _gopath
 
-ifeq ($(BR2_STATIC_LIBS),y)
-$(2)_LDFLAGS += -extldflags '-static'
-endif
-
 $(2)_BUILD_OPTS += \
 	-ldflags "$$($(2)_LDFLAGS)" \
 	-tags "$$($(2)_TAGS)" \
@@ -106,6 +102,11 @@ endif
 # file.
 ifndef $(2)_BUILD_CMDS
 ifeq ($(4),target)
+
+ifeq ($(BR2_STATIC_LIBS),y)
+$(2)_LDFLAGS += -extldflags '-static'
+endif
+
 # Build package for target
 define $(2)_BUILD_CMDS
 	$$(foreach d,$$($(2)_BUILD_TARGETS),\


More information about the buildroot mailing list