[Buildroot] [PATCH] utils/scancpan: fix test file creation on br-external

Arnout Vandecappelle arnout at mind.be
Sun Jun 9 21:39:48 UTC 2019



On 09/06/2019 16:37, Francois Perrad wrote:
> first, add the creation of the needed subdirectories
> 
> Signed-off-by: Francois Perrad <francois.perrad at gadz.org>

 Applied to master, thanks.

 I'm a bit confused about the br-external bit, though. Do we even support having
tests in br-external?

 Regards,
 Arnout

> ---
>  utils/scancpan | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/utils/scancpan b/utils/scancpan
> index 0e7585e31..1fccc980a 100755
> --- a/utils/scancpan
> +++ b/utils/scancpan
> @@ -479,6 +479,7 @@ use Fatal qw(open close);
>  use Getopt::Long;
>  use Pod::Usage;
>  use File::Basename;
> +use File::Path qw(make_path);
>  use Module::CoreList;
>  use HTTP::Tiny;
>  use Safe;
> @@ -715,9 +716,10 @@ while (my ($distname, $dist) = each %dist) {
>      my $mkname = $dirname . q{/} . $fsname . q{.mk};
>      my $hashname = $dirname . q{/} . $fsname . q{.hash};
>      my $brname = brname( $fsname );
> -    my $testname = q{support/testing/tests/package/test_} . lc $brname . q{.py};
> +    my $testdir = q{support/testing/tests/package};
> +    my $testname = $testdir . q{/test_} . lc $brname . q{.py};
>      unless (-d $dirname) {
> -        mkdir $dirname;
> +        make_path $dirname;
>          $new_pkgs = 1;
>      }
>      if ($need_target{$distname} && ($force || !-f $cfgname)) {
> @@ -815,6 +817,7 @@ while (my ($distname, $dist) = each %dist) {
>          my $mark = $is_xs{$distname} ? q{   XS} : q{};
>          my @indirect = (get_indirect_dependencies( $distname ));
>          say qq{write ${testname}} unless $quiet;
> +        make_path $testdir unless -d $testdir;
>          open my $fh, q{>}, $testname;
>          say {$fh} qq{from tests.package.test_perl import TestPerlBase};
>          say {$fh} qq{};
> 



More information about the buildroot mailing list