[Buildroot] [PATCH 2/3] boards/freescale/common: Introduce template_no_boot_part

Joris Offouga offougajoris at gmail.com
Mon Jun 10 19:12:47 UTC 2019


Le 10/06/2019 à 21:00, Arnout Vandecappelle a écrit :
>
> On 10/06/2019 20:43, Joris Offouga wrote:
>> Hi Arnoud,
>>
>> Le 10/06/2019 à 00:17, Arnout Vandecappelle a écrit :
>>> On 09/06/2019 16:57, Joris Offouga wrote:
> [snip]
>>>> diff --git a/board/freescale/common/imx/genimage.cfg.template_no_boot_part b/board/freescale/common/imx/genimage.cfg.template_no_boot_part
>>>> new file mode 100644
>>>> index 0000000000..9e19b4ee3e
>>>> --- /dev/null
>>>> +++ b/board/freescale/common/imx/genimage.cfg.template_no_boot_part
>>>> @@ -0,0 +1,23 @@
>>>> +# Minimal SD card image for the Freescale boards Template
>>>> +#
>>>> +# We mimic the .sdcard Freescale's image format:
>>>> +# * the SD card must have 1 kB free space at the beginning,
>>>   Is this one going to be used by anything in practice? I expect that anything
>>> that uses this kind of layout is *not* going to use the .imx format, since
>>> that's considered kind of deprecated...
>> It depends on the targets, imx7dpico has migrated to the SPL and so its u-boot
>> has gone from .imx to .img,
>>
>> Example of the warp7 on 2019.01 it's still .imx.
>   OK, let me rephrase it then: does U-Boot 2019.01 have any configuration without
> boot FAT partition, but which uses the .imx format instead of SPL?
>
>   In any case, I think this enimage.cfg.template_no_boot_part should only be
> introduced when there is something that actually uses it. Now it is just dead code.

I see you are right if a target will need it it will introduce the 
variable I drop this file,

thanks for review

Best regards,

Joris

>
>   Regards,
>   Arnout
>
> [snip]
>



More information about the buildroot mailing list