[Buildroot] [PATCH 2/2] package/gerbera: add upstream patch to fix find_program with taglib-config

Arnout Vandecappelle arnout at mind.be
Mon Jun 10 22:33:31 UTC 2019



On 10/06/2019 23:20, Jörg Krause wrote:
[snip]
> ++            if (CMAKE_CROSSCOMPILING)
> ++              set(CMAKE_FIND_ROOT_PATH_MODE_PROGRAM ONLY)

 Again, this is wrong IMO. The executables in the sysroot are not supposed to be
executed on the host.

 What we really should do is to copy those config scripts to some other
location, and add that to the PATH.

 Besides, I think gerbera should be using the .pc file rather than the
taglib-config script.

 Moreover, I think taglib should install a TaglibConfig.cmake file so CMake
packages like gerbera can pick that up directly rather than having to write a
FindTaglib file.

 Regards,
 Arnout

> ++            endif(CMAKE_CROSSCOMPILING)
> +             find_program(TAGLIBCONFIG_EXECUTABLE NAMES taglib-config PATHS
> + 		   ${BIN_INSTALL_DIR}
> +             )
> +-- 
> +2.22.0
> +
> 



More information about the buildroot mailing list