[Buildroot] [PATCH 1/1] package/docker-engine: add disable pivot_root option

Peter Korsgaard peter at korsgaard.com
Fri Jun 14 07:10:42 UTC 2019


>>>>>   <yann.morin at orange.com> writes:

 > Frank, All,
 > On 2019-06-13 23:47 +0300, Frank Sigalas spake thusly:
 >> Sets the environment variable DOCKER_RAMDISK before starting dockerd.

 > [--SNIP--]
 >> diff --git a/package/docker-engine/S60dockerd-ramdisk b/package/docker-engine/S60dockerd-ramdisk
 >> new file mode 100644
 >> index 0000000..a1092b6
 >> --- /dev/null
 >> +++ b/package/docker-engine/S60dockerd-ramdisk
 >> @@ -0,0 +1,38 @@
 >> +#!/bin/sh
 >> +
 >> +NAME=dockerd
 >> +DAEMON=/usr/bin/$NAME
 >> +PIDFILE=/var/run/$NAME.pid
 >> +DAEMON_ARGS=""
 >> +
 >> +[ -r /etc/default/$NAME ] && . /etc/default/$NAME $1

 > The existing package/docker-engine/S60dockerd script also parses
 > similarly named file, so why can't you provide (e.g. in an overlay) this
 > configuraiton file taht would just contain:

 >     export DOCKER_RAMDISK=1

 > The config files in /etc/default/ are the place where such local
 > customisations mustr be done.

 > Besides, your solution does not cover the systemd case anyway (for which
 > Christian alrady provided an example). But that is not even needed
 > either, because this is still a local customisation.

Yes, I wonder if running dockerd from an initramfs is really such a
common setup that we want a dedicated option for it rather than just
letting people add such customization in their overlay?

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list