[Buildroot] [PATCH 1/1] utils/test-pkg: Generate package config if it is not specified

Peter Korsgaard peter at korsgaard.com
Wed Mar 27 09:43:49 UTC 2019


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:

 > Hello Vadim,
 > On Fri,  1 Mar 2019 14:33:42 +0200
 > Vadim Kochan <vadim4j at gmail.com> wrote:

 >> From: Vadim Kochan <vadim4j at gmail.com>
 >> 
 >> It is possible to generate one-line config for the package just by
 >> normalize it to the form:
 >> 
 >> BR2_PACKAGE_${pkg_replaced-to_and_uppercase}
 >> 
 >> it simplifes a bit of testing package where no additional config options
 >> are needed.
 >> 
 >> Signed-off-by: Vadim Kochan <vadim4j at gmail.com>
 >> ---
 >> utils/test-pkg | 17 ++++++++++++++++-
 >> 1 file changed, 16 insertions(+), 1 deletion(-)

 > Applied to master, thanks. I was initially a bit skeptical because if
 > the package has a dependency, your solution does not work very well,
 > and users could believe that the package is going to be tested while it
 > won't. But in fact in that case all tests are going to be "SKIPPED"
 > because the BR2_PACKAGE_FOO=y line is not in the final .config. This
 > will clearly tell the user that much not testing has happened. So I'm
 > fine with this, and therefore I applied.

While this isn't a bugfix, it seems quite safe and can be useful for
users - So I've committed it to 2019.02.x as well, thanks.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list