[Buildroot] [PATCH v2, 1/1] package/keepalived: add optional nftables dependency

Baruch Siach baruch at tkos.co.il
Wed Mar 27 17:56:12 UTC 2019


Hi Fabrice,

On Wed, Mar 27, 2019 at 06:45:42PM +0100, Fabrice Fontaine wrote:
> nftables support has been added since version 2.0.11 and
> https://github.com/acassen/keepalived/commit/aa12175ea638912a7789e832634d7ccf80fdf48d
> 
> It depends on libmnl and libnftnl
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> ---
> Changes v1 -> v2 (after review of Baruch Siach, Thomas Petazzoni and
> Arnout Vandecappelle)
>  - nftables support depends on libmnl and libnftnl, it does not depend
>    on iptables's nftables option or nftables package
> 
>  package/keepalived/keepalived.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/keepalived/keepalived.mk b/package/keepalived/keepalived.mk
> index fcdb43ce13..4790cf5689 100644
> --- a/package/keepalived/keepalived.mk
> +++ b/package/keepalived/keepalived.mk
> @@ -46,4 +46,11 @@ else
>  KEEPALIVED_CONF_OPTS += --disable-libiptc
>  endif
>  
> +ifeq ($(BR2_PACKAGE_LIBMNL)$(BR2_PACKAGE_LIBNFTNL),yy)
> +KEEPALIVED_DEPENDENCIES += libmnl libnftnl

BR2_PACKAGE_LIBNFTNL selects BR2_PACKAGE_LIBMNL already. So I think you can 
test for BR2_PACKAGE_LIBNFTNL and depend on libnftnl alone.

> +KEEPALIVED_CONF_OPTS += --enable-nftables
> +else
> +KEEPALIVED_CONF_OPTS += --disable-nftables
> +endif
> +
>  $(eval $(autotools-package))

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -



More information about the buildroot mailing list