[Buildroot] [PATCH 1/1] package/iputils: enable systemd services

[Peter Korsgaard]

>>>>> "Petr" == Petr Vorel <petr.vorel at gmail.com> writes:

Hi,

 > Maybe simplify IPUTILS_CONF_OPTS (diff to your patch)?

 > +++ package/iputils/iputils.mk
 > @@ -46,17 +46,17 @@ IPUTILS_DEPENDENCIES += linux-headers
 >  else
 >  IPUTILS_CONF_OPTS += -DUSE_CRYPTO=none
 >  # BUILD_NINFOD=true and USE_CRYPTO=none cannot be combined
 > -IPUTILS_CONF_OPTS += -DBUILD_NINFOD=false
 >  IPUTILS_NO_NINFOD = y
 >  endif
 
 >  # ninfod requires <pthread.h>
 >  ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
 > -IPUTILS_CONF_OPTS += -DBUILD_NINFOD=false
 >  IPUTILS_NO_NINFOD = y
 >  endif
 
 >  ifneq ($(IPUTILS_NO_NINFOD),y)
 > +IPUTILS_CONF_OPTS += -DBUILD_NINFOD=false
 > +
 >  define IPUTILS_INSTALL_SERVICE_NINFOD
 >  	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
 >  	ln -sf ../../../../lib/systemd/system/ninfod.service \

This doesn't make sense. With this you diable ninfod (by passing
BUILD_NINFOD=false) AND install the service file.

-- 
Bye, Peter Korsgaard