[Buildroot] [PATCH 1/1] Include makefiles from GLOBAL_PATCH_DIR

Yann E. MORIN yann.morin.1998 at free.fr
Thu Nov 7 18:09:58 UTC 2019


Thomas, All,

On 2019-11-06 23:31 +0100, Thomas Petazzoni spake thusly:
> On Wed, 6 Nov 2019 17:37:48 +0100
> "Yann E. MORIN" <yann.morin.1998 at free.fr> wrote:
[--SNIP--]
> > So, I am afraid that these overrides are a poor excuse for not wanting to
> > do actual VCS work.
> Well, you are the one who introduced BR2_EXTERNAL in the first place!

Ahem... git show a4239f7fd10 ;-)

I did introduce support for multi br2-external, though.

Anyway, this patch, as on IRC by Jérémy, has a designe flaw: since the
override files are included too early, they hcamge the way pkgdir is
computed, and this breaks completely.

This can be corrected, though, and it might even not be too complex to
do.

But if we're going to do the override stuff, I think we must think it
thouroughly, and not use an half-baked solution.

If at all, I'd favour looking at the aternate solution that was floated
around during the last devdays: postpone evaluation of the infras to
after all the packages hav actually been scanned. This would even allow
overriding the type of a package (e.g. autotools-package instead of
meson-package, in case the version was changed to use another
buildsystem).

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'



More information about the buildroot mailing list