[Buildroot] [PATCH 1/1] Include makefiles from GLOBAL_PATCH_DIR

Jérémy ROSEN jeremy.rosen at smile.fr
Thu Nov 7 21:47:21 UTC 2019


Yes I was about to post that

for units that have both a target and a host  mode, the .mk is included
twice.

This is rather easy to fix (probably just  add a flag to avoid double
include) but since the patch is still being discussed on a philosophical
ground, I'll wait before submitting a V2

Le jeu. 7 nov. 2019 à 19:15, Yann E. MORIN <yann.morin.1998 at free.fr> a
écrit :

> All,
>
> On 2019-11-07 19:09 +0100, Yann E. MORIN spake thusly:
> > On 2019-11-06 23:31 +0100, Thomas Petazzoni spake thusly:
> > > On Wed, 6 Nov 2019 17:37:48 +0100
> > > "Yann E. MORIN" <yann.morin.1998 at free.fr> wrote:
> > [--SNIP--]
> > > > So, I am afraid that these overrides are a poor excuse for not
> wanting to
> > > > do actual VCS work.
> > > Well, you are the one who introduced BR2_EXTERNAL in the first place!
> >
> > Ahem... git show a4239f7fd10 ;-)
> >
> > I did introduce support for multi br2-external, though.
> >
> > Anyway, this patch, as on IRC by Jérémy, has a designe flaw: since the
>
> *as discussed on IRC with ... a design flaw...
>
> > override files are included too early, they hcamge the way pkgdir is
>
> * change
>
> > computed, and this breaks completely.
> >
> > This can be corrected, though, and it might even not be too complex to
> > do.
> >
> > But if we're going to do the override stuff, I think we must think it
> > thouroughly, and not use an half-baked solution.
> >
> > If at all, I'd favour looking at the aternate solution that was floated
> > around during the last devdays: postpone evaluation of the infras to
> > after all the packages hav actually been scanned. This would even allow
> > overriding the type of a package (e.g. autotools-package instead of
> > meson-package, in case the version was changed to use another
> > buildsystem).
>
> ... and thus we could drop the check that a package is not redefined,
> and so a package could be redefined in a br2-external tree, and that
> would not need any new override mechanism at all, presumably.
>
> Regards,
> Yann E. MORIN.
>
> --
>
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
>      |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is
> no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
>  conspiracy.  |
>
> '------------------------------^-------^------------------^--------------------'
>


-- 
[image: SMILE]  <http://www.smile.eu/>

20 rue des Jardins
92600 Asnières-sur-Seine
*Jérémy ROSEN*
Architecte technique

[image: email] jeremy.rosen at smile.fr
[image: phone]  +33 6 88 25 87 42
[image: url] http://www.smile.eu

[image: Twitter] <https://twitter.com/GroupeSmile> [image: Facebook]
<https://www.facebook.com/smileopensource> [image: LinkedIn]
<https://www.linkedin.com/company/smile> [image: Github]
<https://github.com/Smile-SA>

[image: Découvrez l’univers Smile, rendez-vous sur smile.eu]
<https://www.smile.eu/fr/publications/livres-blancs/yocto?utm_source=signature&utm_medium=email&utm_campaign=signature>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191107/804b85af/attachment-0002.html>


More information about the buildroot mailing list