[Buildroot] [PATCH 1/2] package/gcnano-binaries: new package

[Thomas Petazzoni]

Hello Jens,

On Mon, 11 Nov 2019 11:19:31 +0100
"Jens Kleintje" <Scooby22 at web.de> wrote:

> > Please use the "github" helper macro:  
> 
> > GCNANO_BINARIES_VERSION = c01642ed5e18cf09ecd905af193e935cb3be95ed
> > GCNANO_BINARIES_SITE = $(call github,STMicroelectronics,gcnano-binaries,$(GCNANO_BINARIES_VERSION))  
> 
> > and remove the _SITE_METHOD variable.  
> The page (https://github.com/STMicroelectronics/gcnano-binaries)
> has no release and no tag. So I think there is no archive directory.

Not a problem, the github macro works with any arbitrary commit.

> > > + rm -f $(STAGING_DIR)/usr/lib/pkgconfig/wayland-egl.pc  
> 
> > Why are you removing this .pc file ?  
> The file is already provided by wayland package.
> I saw it from in the yocto package  
> https://github.com/STMicroelectronics/meta-st-stm32mp/blob/thud/recipes-graphics/gcnano-userland/gcnano-userland-binary.inc

Then, if you could add a comment in the .mk file about this, it would
be good.

> > Could you rework your patch to take into account those comments ?  
> Will come soon.

Great, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com