[Buildroot] [PATCH 1/1] package/kmod: fix build with python 3.8

[Yann E. MORIN]

Fabrice, All,

On 2019-11-16 17:23 +0100, Yann E. MORIN spake thusly:
> On 2019-11-16 12:45 +0100, Fabrice Fontaine spake thusly:
> > Replace second patch that adds -Wl,-z,undefs by a patch that remove
> > -Wl,--no-undefined as some ld versions are ignoring this flag:
[--SNIP--]
> > -diff --git a/Makefile.am b/Makefile.am
> > -index c5c2f06..8e9c90d 100644
> > ---- a/Makefile.am
> > -+++ b/Makefile.am
> > -@@ -173,7 +173,7 @@ CPYTHON_MODULE_CFLAGS = \
> > - 	$(AM_CFLAGS) -DCPYTHON_COMPILING_IN_PYPY=0 \
> > - 	$(PYTHON_NOWARN) $(PYTHON_CFLAGS) \
> > - 	-fvisibility=default
> > --CPYTHON_MODULE_LDFLAGS = $(AM_LDFLAGS) -module -avoid-version -shared
> > -+CPYTHON_MODULE_LDFLAGS = $(AM_LDFLAGS) -module -avoid-version -shared -Wl,-z,undefs
> 
> What about this hack:
> 
>     CPYTHON_MODULE_LDFLAGS = (subst -Wl,--no-undefined,,$(AM_LDFLAGS)) ...

Does not work because of commas. The good hack would be:

    comma = ,
    CPYTHON_MODULE_LDFLAGS = (subst -Wl$(comma)--no-undefined,,$(AM_LDFLAGS)) ...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'