[Buildroot] [PATCH] system: allow not setting a default, system-wide time zone

[Yann E. MORIN]

Arnout, All,

On 2019-11-17 15:41 +0100, Arnout Vandecappelle spake thusly:
> On 16/11/2019 10:10, Yann E. MORIN wrote:
> > It is valid that there is no system-wide default time zone defined, in
> > which case Etc/UTC is assumed.
> > 
> > Fixes: #12316
> > 
> > Signed-off-by: Yann E. MORIN <yann.morin.1998 at free.fr>
> > Cc: Martin Bark <martin at barkynet.com>
> > Cc: Alexandre Belloni <alexandre.belloni at bootlin.com>
> > Cc: Richard Braun <rbraun at sceen.net>
> > Cc: Andrew Trapani <andrew.trapani at ontera.bio>
> [snip]
> > diff --git a/system/Config.in b/system/Config.in
> > index c87266f431..c8c5be40e0 100644
> > --- a/system/Config.in
> > +++ b/system/Config.in
> > @@ -494,6 +494,8 @@ config BR2_TARGET_LOCALTIME
> >  	    Pacific/Wallis
> >  	    ...
> >  
> > +	  Set to empty to not install a default time zone.
> 
>  Maybe we should then also change the default to empty?

I disagree. I prefer there is an explicit default, which makes it
obvious what it means, rather than use an implicit setting.

> Then at least this use
> case gets tested in the autobuilders. Oh, maybe adding a few possible values for
> this config in genrandconfig would be nice as well...

If you enable the randomisation in genrandconfig, then there is no
longer any reason to set the default to empty, is there?

>  BTW, I notice now that BR2_TARGET_TZ_ZONELIST is not used for uClibc (tz). Is
> that expected? Maybe it should depend on !UCLIBC then?

I think this should be done in a further patch. Having a value that is
not used in the uClibc case is not a regression: it's been like that for
years now, since 2014 with commit 337fbd549c.

On the other hand, this patch fixes an existing issue (#12316).

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'