[Buildroot] [EXT] Re: [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package

[Michael Walle]

Hi,
>> > +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS
>> > +     cd $(@D); \
>> > +             sh
>> >
>> $(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SO
>> URCE)
>> > --auto-accept;
>> > +endef
>> 
>> There is already an FREESCALE_IMX_EXTRACT_HELPER macro. I guess that
>> should be renamed and used here.
> 
> I changed this codes accordance with freescale-imx, create new option
> FREESCALE_QORIQ_EXTRACT_HELPER

why FREESCALE_QORIQ_EXTRACT_HELPER? are there two different ones now?
Shouldn't it be just FREESCALE_EXTRACT_HELPER? and the definition of the 
macro should be moved out of the freescale-imx.mk?

or of course, there might be another subdirectory structure like:
packages/freescale/imx
packages/freescale/qoriq
pacakges/freescale/helper.mk

Or..

packages/freescale/fsl-imx-<package>
packages/freescale/fsl-qoriq-<package>
pacakges/freescale/helper.mk

And the macro might end up in the pacakges/freescale/helper.mk file.

TBH. I guess there have to be a cleanup before adding the qoriq stuff. 
Thomas? Matthew?

-michael