[Buildroot] [PATCH v2] package/pkg-kconfig: fix reconfigure for kconfig packages

Angelo Compagnucci angelo at amarulasolutions.com
Tue Nov 26 13:22:26 UTC 2019


On Tue, Nov 26, 2019 at 2:18 PM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> On Tue, 26 Nov 2019 13:24:23 +0100
> Angelo Compagnucci <angelo at amarulasolutions.com> wrote:
>
> > From: Angelo Compagnucci <angelo.compagnucci at gmail.com>
> >
> > Commit 4b81badbcc0b25678ac6627548160702731cf393
> >
> >     Currently, calling foo-reconfigure for a kconfig-based package will not
> >     re-trigger the configuration (kconfig-wise) step for the package.
> >
> > already solved this problem, but it was lately regressed by
> >
> > Commit 05fea6e4a60a38a797d9bacbf318a2cd7dbd435f
>
> Are you sure it was regressed ? When I read the code at commit
> 4b81badbcc0b25678ac6627548160702731cf393, I don't see even back then
> how linux-reconfigure would trigger a complete reconfiguration. Have
> you actually verified that it was working as expected back at commit
> 4b81badbcc0b25678ac6627548160702731cf393 ? Indeed, at commit
> 4b81badbcc0b25678ac6627548160702731cf393, we were already only removing
> the stamp_kconfig_fixup_done stamp file, so my understanding is rather
> that commit 4b81badbcc0b25678ac6627548160702731cf393 doesn't implement
> what the commit log says.

Not tested that commit really, I guessed based on what the commit messages said.

I'll rework the commit message .

Thanks!

>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com



More information about the buildroot mailing list