[Buildroot] [PATCH] package/pkg-generic: fix reconfigure for kconfig packages

Arnout Vandecappelle arnout at mind.be
Tue Nov 26 22:54:04 UTC 2019



On 25/11/2019 18:32, Thomas Petazzoni wrote:
> However, there seems to be some disagreement on IRC where
> "foo-reconfigure" on a kconfig package implies that the configuration
> of the package is completely regenerated, therefore losing any local
> change that may have been done using "foo-menuconfig". We need to sort
> out this disagreement before we can merge a patch like this.

 The word "reconfigure" by itself could mean either option: run 'olddefconfig'
on the current .config (which is what is done now), or recreate the .config from
its inputs (which is what this patch makes it do).

 I think the latter is a *lot* more useful than the former. The current
situation is only useful if you're either modifying the .config directly
(without foo-menuconfig), or if you're modifying the Kconfig files in an
OVERRIDE_SRCDIR. Modifying the .config directly is clearly not something we need
to support. Modifying Kconfig files in OVERRIDE_SRCDIR is something we should
support, but even then it makes a lot of sense to reconstruct the .config from
the inputs rather than trying to reuse the locally modified .config.

 Bottom line: I think it's a good change (if done in pkg-kconfig like Thomas
proposed).

 It'll need to be mentioned in the release notes however.

 Regards,
 Arnout




More information about the buildroot mailing list