[Buildroot] [PATCH 1/1] check-package: add version format check

Heiko Thiery heiko.thiery at gmail.com
Fri Oct 25 08:15:00 UTC 2019


From: Heiko Thiery <heiko.thiery at kontron.com>

To meet the requirement of "Anitya", the tool used by
https://release-monitoring.org/, the <pkg>_VERSION variable
should not contain a prefix 'v'.

Signed-off-by: Heiko Thiery <heiko.thiery at kontron.com>
---
 utils/checkpackagelib/lib_mk.py | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/utils/checkpackagelib/lib_mk.py b/utils/checkpackagelib/lib_mk.py
index dd04ffd58f..ffde48e05b 100644
--- a/utils/checkpackagelib/lib_mk.py
+++ b/utils/checkpackagelib/lib_mk.py
@@ -325,3 +325,28 @@ class VariableWithBraces(_CheckFunction):
             return ["{}:{}: use $() to delimit variables, not ${{}}"
                     .format(self.filename, lineno),
                     text]
+
+
+class Version(_CheckFunction):
+    VERSION = re.compile(r"^([A-Z0-9_]+)_VERSION\s*[\+|:|]*=\s*(.*)")
+    GIT_HASH = re.compile("([A-Za-f0-9]{40})")
+
+    def _is_git_hash(self, value):
+        return True if self.GIT_HASH.match(value) else False
+
+    def check_line(self, lineno, text):
+        m = self.VERSION.search(text)
+        if m is None:
+            return
+
+        variable, assignment = m.group(1, 2)
+
+        if self._is_git_hash(assignment):
+            return
+
+        if assignment.startswith('v'):
+            return ["{}:{}: remove 'v' prefix from {} of variable {}_VERSION "
+                    "and add to {}_SITE"
+                    .format(self.filename, lineno, assignment, variable,
+                            variable),
+                    text]
-- 
2.20.1



More information about the buildroot mailing list