[Buildroot] [PATCH] toolchain-external: restrict copying of dynamic loader to ld*.so.*

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun Oct 27 13:59:21 UTC 2019


Hello,

On Tue,  5 Feb 2019 22:15:44 +0100
Thomas De Schampheleire <patrickdepinguin at gmail.com> wrote:

> From: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>
> 
> Commit 32bec8ee2fb00c6750fa842bbb0eb79b0c081fa2
> ("toolchain-external: copy ld*.so* for all C libraries") changed (among
> other things) the glob pattern to catch the dynamic loader from
>     ld*.so.*
> to
>     ld*.so*
> 
> thus now matching files like 'ld-2.20.so' in addition to files like
> 'ld.so.1'.
> 
> However, there is no apparent reason why that change was made. It is not
> explicitly mentioned in the commit message as to why that would be needed,
> nor is clear based on the rest of the changes in that commit.
> 
> The consequence of the change is that more files than needed end up in the
> target root filesystem, adding extra unnecessary size to it.
> 
> Therefore, revert the glob pattern back to what it was.
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>

Thanks Thomas! As you know, we like this kind of patch to bitrot for a
few months in patchwork, to finally apply them.

So this is what just happened: I applied your patch, after
significantly extending the commit log with additional explanations
from your lengthy reply in this thread.

Thanks for your patience!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


More information about the buildroot mailing list