[Buildroot] [PATCH 1/1] package/python-brotlipy: new package

Arnout Vandecappelle arnout at mind.be
Sun Oct 27 14:02:34 UTC 2019


 Hi James,

 Sorry for the extremely late reply to this one.

On 16/03/2019 03:36, james.hilliard1 at gmail.com wrote:
> From: James Hilliard <james.hilliard1 at gmail.com>
> 
> Python binding to the Brotli library.
> 
> Signed-off-by: James Hilliard <james.hilliard1 at gmail.com>
[snip]
> diff --git a/package/python-brotlipy/python-brotlipy.mk b/package/python-brotlipy/python-brotlipy.mk
> new file mode 100644
> index 0000000000..f51376fab2
> --- /dev/null
> +++ b/package/python-brotlipy/python-brotlipy.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# python-brotlipy
> +#
> +################################################################################
> +
> +PYTHON_BROTLIPY_VERSION = 0.7.0
> +PYTHON_BROTLIPY_SOURCE = brotlipy-$(PYTHON_BROTLIPY_VERSION).tar.gz
> +PYTHON_BROTLIPY_SITE = https://files.pythonhosted.org/packages/d9/91/bc79b88590e4f662bd40a55a2b6beb0f15da4726732efec5aa5a3763d856
> +PYTHON_BROTLIPY_SETUP_TYPE = setuptools
> +PYTHON_BROTLIPY_LICENSE = MIT
> +PYTHON_BROTLIPY_LICENSE_FILES = LICENSE libbrotli/LICENSE
> +PYTHON_BROTLIPY_DEPENDENCIES = host-python-cffi

 You're using the bundled libbrotli instead of our own brotli package, which we
don't like. Apparently, there's an upstream commit bd202a98e44947aaed2345 that
allows to use an external brotli. Could you respin using that?

 Note that also means you don't need libbrotli/LICENSE in the license files. And
you don't need your patch any more.

 Regards,
 Arnout

> +
> +$(eval $(python-package))
> 


More information about the buildroot mailing list