[Buildroot] [PATCH 2/2] package/gcc: add support for D language

[Thomas Petazzoni]

On Mon, 7 Oct 2019 23:09:28 +0200
Arnout Vandecappelle <arnout at mind.be> wrote:

> > config BR2_TOOLCHAIN_CAN_SUPPORT_DLANG
> > 	bool
> > 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_9
> > 	depends on BR2_TOLCHAIN_USES_GLIBC
> > 	default y if BR2_arm
> > 	default y if BR2_x86_64
> > 	default y if ...
> > 
> > and then re-use that for both the internal and external toolchain cases.  
> 
>  Nack that. An external toolchain may use a gcc branch that does support
> additional architectures or a different libc or a gcc version < 9. So for the
> external toolchain, there should just be a BR2_TOOLCHAIN_EXTERNAL_CUSTOM_DLANG
> that is user-settable (and verified with a compiler test).

That's true. I thought about that when writing my reply, but didn't see
a good solution to handle that.

>  Also, there should be a hidden BR2_TOOLCHAIN_HAS_DLANG option that gets
> selected by BR2_TOOLCHAIN_BUILDROOT_DLANG and
> BR2_TOOLCHAIN_EXTERNAL_CUSTOM_DLANG (and possibly by other external toolchains
> in the future).

This is exactly what I suggested in my initial reply to Eric's patches.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com