[Buildroot] [PATCH 1/1] package/brltty: fix build with expat

Fabrice Fontaine fontaine.fabrice at gmail.com
Wed Oct 9 17:16:31 UTC 2019


Dear Thomas,

Le sam. 5 oct. 2019 à 22:37, Thomas Petazzoni
<thomas.petazzoni at bootlin.com> a écrit :
>
> On Tue, 1 Oct 2019 08:42:24 +0200
> Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:
>
> > > Maybe it's because it's late and I'm no longer thinking properly, but
> > > do you understand how disabling expat prevents the cldr program from
> > > being built, and therefore the tbl2hex utility tool from being built ?
> > > They seem to be unconditionally built by Programs/Makefile.in.
> > cldr.c is mostly an empty shell without expat as most of the code is
> > protected by ifdef HAVE_EXPAT blocks, see
> > https://github.com/brltty/brltty/blob/aba3d8cc2dc765a0933aabb609928e568e085d39/Programs/cldr.c.
>
> OK, but where is the logic that links with -lexpat when it's available,
> and doesn't link with -lexpat when not available ? I'm a bit confused
> by the build logic of this package I must say.
Linking with expat is done through EXPAT_LIBS in Programs/Makefile.in.
EXPAT_LIBS is set to @expat_libs@ in config.mk.in.
expat_libs is set in configure.ac depending on BRLTTY_HAVE_PACKAGE
result (which is basically a pkg-config wrapper defined in
m4/brltty.m4).
The main issue with this package is that it assumes that if expat is
available on target then it is also available on host.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice



More information about the buildroot mailing list