[Buildroot] [PATCH 1/3] package/lttng-libust: bump version to 2.11.0

Philippe Proulx eeppeliteloop at gmail.com
Tue Oct 22 20:20:36 UTC 2019


On Tue, Oct 22, 2019 at 3:59 PM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> On Tue, 22 Oct 2019 10:48:03 -0400
> Philippe Proulx <eeppeliteloop at gmail.com> wrote:
>
> > +ifneq ($(BR2_PACKAGE_NUMACTL),y)
> > +LTTNG_LIBUST_CONF_OPTS += --disable-numa
> > +endif
>
> This is not good: what happens when numactl is enabled ?
>
> So, I changed this to:
>
> ifeq ($(BR2_PACKAGE_NUMACTL),y)
> LTTNG_LIBUST_DEPENDENCIES += numactl
> LTTNG_LIBUST_CONF_OPTS += --enable-numa
> else
> LTTNG_LIBUST_CONF_OPTS += --disable-numa
> endif
>
> which is the typical way to handle optional dependencies.
>
> I've applied after fixing this. Thanks!

Ok thanks.

`--enable-numa` is the default which is why I didn't write it
explicitly, but it looks safer your way.

Phil
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com



More information about the buildroot mailing list