[Buildroot] [PATCH v2 2/2] package/ofono: use target ell library if enabled

[Nicolas Serafini]

Hello Thomas,

On Tue, 22 Oct 2019 22:18:00 +0200 Thomas Petazzoni <thomas.petazzoni at bootlin.com> wrote:

>Hello Nicolas,
>
>On Tue, 22 Oct 2019 13:44:08 +0000
>Nicolas Serafini <nicolas.serafini at sensefly.com> wrote:
>
>> +ifeq ($(BR2_PACKAGE_ELL),y)
>> +OFONO_DEPENDENCIES += ell
>> +OFONO_CONF_OPTS += --enable-external-ell
>> +else
>> +OFONO_CONF_OPTS += --disable-external-ell
>> +endif
>
>If I understand correctly the code, ell is in fact always needed by
>ofono. If ell is not available externally, it uses a bundled version of
>ell.

Yes, that's right.

>
>In this case, Buildroot prefers to always use the external library, so
>could you turn ell into a mandatory dependency of ofono, and pass
>--enable-external-ell unconditionally?

I also prefer to use only the external library.
In case of a bug it avoids maintaining a patch in two different packages.
I'm preparing a v3.

Thanks

Nicolas

>
>Thanks!
>
>Thomas