[Buildroot] [RFC PATCH v2 06/30] lld: new package

Romain Naour romain.naour at smile.fr
Thu Oct 24 20:23:46 UTC 2019


Hello Joseph,

Le 24/10/2019 à 22:18, Joseph Kogut a écrit :
> Hello Romain,
> 
> On Thu, Oct 24, 2019 at 1:05 PM Romain Naour <romain.naour at smile.fr> wrote:
>>
>> Hello Joseph,
>>
>> Le 24/10/2019 à 21:56, Joseph Kogut a écrit :
>>> On Thu, Oct 24, 2019 at 12:38 PM Romain Naour <romain.naour at smile.fr> wrote:
>>>>
>>>> Le 24/10/2019 à 21:35, Romain Naour a écrit :
>>>>> Hi Arnout,
>>>>>
>>>>> Le 20/10/2019 à 00:39, Arnout Vandecappelle a écrit :
>>>>>>> +++ b/package/lld/Config.in.host
>>>>>>> @@ -0,0 +1,16 @@
>>>>>>> +config BR2_PACKAGE_HOST_LLD
>>>>>>> +   bool "host lld"
>>>>>>> +   depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS # llvm
>>>>>>> +   depends on BR2_HOST_GCC_AT_LEAST_4_8 # llvm
>>>>>>> +   select BR2_PACKAGE_HOST_LLVM
>>>>>>
>>>>>>  I'm confused now... I thought the previous patch would be needed to support
>>>>>> lld, but you don't select BR2_PACKAGE_HOST_LLVM_ENABLE_HOST_ARCH here, so the
>>>>>> option introduced in the previous patch is not used at all... Why is that patch
>>>>>> needed then?
>>>>>>
>>>>>>
>>>>>>  Also, in Joseph's original submission, [1] was included. Now it is no longer
>>>>>> there. Was it not needed after all?
>>>>>>
>>>>>>  Anyway, I think I'll apply Joseph's original patch now.
>>>>>
>>>>> Thanks for merging lld :)
>>>>>
>>>>> But lld package needs to be at the same version as llvm (currently 9.0.0).
>>>>> lld package was sent to the mailing list at the time where llvm package was
>>>>> using 8.0.0.
>>>>>
>>>
>>> I've been getting emails about the build failures, and I arrived at
>>> the same conclusion yesterday. If nobody else is working on this, I
>>> can send patches in to fix these issues later today.
>>
>> Bumping the package version is easy, I'm doing it right now.
>> But I don't have time to do a runtime test, can you do it?
>>
> 
> Yes, I can handle that.
> 

You're welcome :)

See: http://patchwork.ozlabs.org/project/buildroot/list/?series=138492

Best regards,
Romain




More information about the buildroot mailing list