[Buildroot] [PATCH] package/jitterentropy-library: fix build failure due to missing -fPIC

Arnout Vandecappelle arnout at mind.be
Fri Oct 25 19:57:35 UTC 2019



On 25/10/2019 21:23, Peter Korsgaard wrote:
>>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:
> 
> Hi,
> 
>  >> >  Hm, but maybe there are indeed good reasons to override the CFLAGS, because the
>  >> > fstack-protector-all requires support from the toolchain. On the other hand, we
>  >> > probably *do* want to keep the -O0 and -fwrapv flags...
>  >> 
>  >> The fstack-protector-* options should be handled by BR2_SSP_* and
>  >> hardcoded in the package. 
> 
>  >  If with "hardcoded in the package" you mean "set by the package's .mk file",
>  > then I disagree, since it is passed by the toolchain wrapper.
> 
> Sorry, there was a NOT missing, E.G. NOT hardcoded in .mk.

 Yes, that's what I meant to say: CFLAGS should be overridden because we *don't*
want the Makefile's stack-protector option, because the toolchain may not
support it.

 Regards,
 Arnout

> 
>  >> Why would we want to use -O0?
> 
>  >  The package description is "Hardware RNG based on CPU timing jitter." I expect
>  > that compiler optimisations mess with CPU timing jitter.
> 
> Ah yes, possibly.
> 



More information about the buildroot mailing list