[Buildroot] [PATCH] toolchain: introduce config options to include GCC's sanitation libraries

[Matthew Weber]

Markus,

On Sat, Oct 26, 2019 at 1:29 PM Markus Mayer <mmayer at broadcom.com> wrote:
>
> Hi all,
>
> On Wed, 5 Jun 2019 at 14:42, Markus Mayer <mmayer at broadcom.com> wrote:
> >
> > We add config options for external toolchains to allow copying the
> > following libraries into the root file system:
> >
> >   - libasan (-fsanitize=address)
> >   - liblsan (-fsanitize=leak)
> >   - libtsan (-fsanitize=thread)
> >   - libubsan (-fsanitize=undefined)
> >
> > Copying these shared libraries into the root file system will add
> > run-time support for binaries compiled with one of the above "sanitize"
> > options for enhanced run-time debugging.
>
[snip]

> > --- a/toolchain/Config.in
> > +++ b/toolchain/Config.in
> > @@ -632,4 +632,16 @@ config BR2_TOOLCHAIN_HAS_LIBQUADMATH
> >         bool
> >         default y if BR2_i386 || BR2_x86_64
> >
> > +config BR2_TOOLCHAIN_HAS_LIBASAN
> > +       bool
> > +
> > +config BR2_TOOLCHAIN_HAS_LIBLSAN
> > +       bool
> > +
> > +config BR2_TOOLCHAIN_HAS_LIBTSAN
> > +       bool
> > +
> > +config BR2_TOOLCHAIN_HAS_LIBUBSAN
> > +       bool
> > +
> >  endmenu
> > diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk b/toolchain/toolchain-external/pkg-toolchain-external.mk
> > index baf719ad1f09..ca4dd00446b5 100644
> > --- a/toolchain/toolchain-external/pkg-toolchain-external.mk
> > +++ b/toolchain/toolchain-external/pkg-toolchain-external.mk
> > @@ -148,6 +148,22 @@ ifeq ($(BR2_TOOLCHAIN_HAS_OPENMP),y)
> >  TOOLCHAIN_EXTERNAL_LIBS += libgomp.so.*
> >  endif
> >
> > +ifeq ($(BR2_TOOLCHAIN_HAS_LIBASAN),y)
> > +TOOLCHAIN_EXTERNAL_LIBS += libasan.so*
> > +endif
> > +
> > +ifeq ($(BR2_TOOLCHAIN_HAS_LIBLSAN),y)
> > +TOOLCHAIN_EXTERNAL_LIBS += liblsan.so*
> > +endif
> > +
> > +ifeq ($(BR2_TOOLCHAIN_HAS_LIBTSAN),y)
> > +TOOLCHAIN_EXTERNAL_LIBS += libtsan.so*
> > +endif
> > +
> > +ifeq ($(BR2_TOOLCHAIN_HAS_LIBUBSAN),y)
> > +TOOLCHAIN_EXTERNAL_LIBS += libubsan.so*
> > +endif

Aside from build time impacts, would there be any reason to not just
enable these by default in GCC > 4.8 ?


> > +
> >  TOOLCHAIN_EXTERNAL_LIBS += $(call qstrip,$(BR2_TOOLCHAIN_EXTRA_EXTERNAL_LIBS))
> >
> >
> > diff --git a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> > index cb7095632fff..c62745103740 100644
> > --- a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> > +++ b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options
> > @@ -437,6 +437,34 @@ config BR2_TOOLCHAIN_EXTERNAL_OPENMP
> >           support. If you don't know, leave the default value,
> >           Buildroot will tell you if it's correct or not.
> >
> > +config BR2_TOOLCHAIN_EXTERNAL_LIBASAN
> > +       bool "Toolchain has libasan support?"
> > +       select BR2_TOOLCHAIN_HAS_LIBASAN
> > +       help
> > +         Select this option if your external toolchain has libasan
> > +         support (-fsanitize=address).
> > +
> > +config BR2_TOOLCHAIN_EXTERNAL_LIBLSAN
> > +       bool "Toolchain has liblsan support?"
> > +       select BR2_TOOLCHAIN_HAS_LIBLSAN
> > +       help
> > +         Select this option if your external toolchain has libasan
> > +         support (-fsanitize=leak).
> > +
> > +config BR2_TOOLCHAIN_EXTERNAL_LIBTSAN
> > +       bool "Toolchain has libtsan support?"
> > +       select BR2_TOOLCHAIN_HAS_LIBTSAN
> > +       help
> > +         Select this option if your external toolchain has libasan
> > +         support (-fsanitize=thread).
> > +
> > +config BR2_TOOLCHAIN_EXTERNAL_LIBUBSAN
> > +       bool "Toolchain has libasan support?"
> > +       select BR2_TOOLCHAIN_HAS_LIBUBSAN
> > +       help
> > +         Select this option if your external toolchain has libubsan
> > +         support (-fsanitize=undefined).
> > +
> >  config BR2_TOOLCHAIN_EXTRA_EXTERNAL_LIBS
> >         string "Extra toolchain libraries to be copied to target"
> >         help
> > --
> > 2.17.1
> >
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot



-- 

Matthew Weber | Associate Director Software Engineer | Commercial Avionics

COLLINS AEROSPACE

400 Collins Road NE, Cedar Rapids, Iowa 52498, USA

Tel: +1 319 295 7349 | FAX: +1 319 263 6099

matthew.weber at collins.com | collinsaerospace.com



CONFIDENTIALITY WARNING: This message may contain proprietary and/or
privileged information of Collins Aerospace and its affiliated
companies. If you are not the intended recipient, please 1) Do not
disclose, copy, distribute or use this message or its contents. 2)
Advise the sender by return email. 3) Delete all copies (including all
attachments) from your computer. Your cooperation is greatly
appreciated.


Any export restricted material should be shared using my
matthew.weber at corp.rockwellcollins.com address.