[Buildroot] [PATCH v2 6/7] support/scripts/qemu-boot-*: gitlab tests for Qemu

[Thomas Petazzoni]

On Sun, 27 Oct 2019 15:32:00 +0100
Romain Naour <romain.naour at smile.fr> wrote:

> > For the x86_64 case, maybe we should simply rename board/qemu/x86_64 to
> > board/qemu/x86-64, so that it matches the other directories, where we
> > have the same name as the defconfig, with just the _ replaced by -.
> > This would entirely remove those special conditions.  
> 
> Instead of renaming this directory and using the name of the defconfig file to
> search for the right readme.txt containing the qemu command line to use.
> 
> We can instead add a comment in the defconfig
> 
> $ cat qemu_aarch64_virt_defconfig
> # Use the Qemu command line from board/qemu/arm-vexpress/readme.txt to start Qemu.
> 
> or if we use a script launch.sh to start qemu (as suggested in the previous
> patch review)
> 
> # Use the script from board/qemu/arm-vexpress/launch.sh to start Qemu.
> 
> Doing so, we don't have a naming rule between defconfig file and board/qemu
> directory.

Yes, why not. Could be useful to point people at the readme.txt or
launch.sh script.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com