[Buildroot] [PATCH] package/cups-filters: fix build without NLS

Carlos Santos unixmania at gmail.com
Thu Sep 19 04:00:05 UTC 2019


On Mon, Sep 16, 2019 at 4:00 PM Carlos Santos <unixmania at gmail.com> wrote:
>
> On Thu, Aug 1, 2019 at 1:29 PM Thomas Petazzoni
> <thomas.petazzoni at bootlin.com> wrote:
> >
> > On Mon, 22 Jul 2019 04:11:46 -0300
> > unixmania at gmail.com wrote:
> >
> > > +# texttotext must be linked to libiconv if !BR2_ENABLE_LOCALE. We could patch
> > > +# configure.ac to use AM_ICONV but it would require iconv.m4, increasing the
> > > +# patch size by at least 130 lines. Let's keep it simple and just patch
> > > +# Makefile.am to append -liconv to the link command line.
> >
> > Why is this AM_ICONV solution taking at least 130 lines ? This would be
> > upstreamable, and looks a lot nicer. Could you propose a patch with an
> > AM_ICONV base solution instead ?
> >
> > Thanks!
>
> A change solving this was accepted upstream so I will submit a
> follow-up with that fix:
>
>    https://github.com/OpenPrinting/cups-filters/pull/155
>
> --
> Carlos Santos <unixmania at gmail.com>

Patch updated:

    https://patchwork.ozlabs.org/patch/1164349/

I also sent a second patch, fixing a broken symlink:

    https://patchwork.ozlabs.org/patch/1164350/

-- 
Carlos Santos <unixmania at gmail.com>



More information about the buildroot mailing list