[Buildroot] [PATCH 1/1] arch/riscv: set the default float ABI based on ISA extensions

Thomas Petazzoni thomas.petazzoni at bootlin.com
Thu Sep 19 19:51:01 UTC 2019


Hello Mark,

On Thu, 19 Sep 2019 16:40:35 +0100
Mark Corbin <mark.corbin at embecosm.com> wrote:

> This patch sets the default floating point ABI based on the ISA
> extensions that have been selected rather than defaulting to soft
> float.
> 
> For 64-bit:
> 
> ISA 'D' selects  lp64d
> ISA 'F' selects  lp64f
> Otherwise select lp64
> 
> For 32-bit:
> 
> ISA 'D' selects  ilp32d
> ISA 'F' selects  ilp32f
> Otherwise select ilp32
> 
> This change was proposed by Palmer Dabbelt at SiFive.
> 
> Signed-off-by: Mark Corbin <mark.corbin at embecosm.com>
> Reviewed-by: Palmer Dabbelt <palmer at sifive.com>
> ---
>  arch/Config.in.riscv | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Applied to master, thanks. However, I'm wondering: does it really makes
sense to offer a choice of the ABI ? Would there be a reason for a user
to use lp64 if he has the D ISA for example ? It would seem logical to
simply use lp64d as soon as you have the D ISA.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list