[Buildroot] [PATCH v2] configs/pc_x86_64_efi: add GPT partition table support.

[Carlos Santos]

On Sun, Sep 22, 2019 at 8:36 AM Thomas Petazzoni
<thomas.petazzoni at bootlin.com> wrote:
>
> Hello Carlos,
>
> Thanks for following up on this.
>
> On Sat, 21 Sep 2019 21:03:23 -0300
> unixmania at gmail.com wrote:
>
> > -cp -f "$BOARD_DIR/grub-bios.cfg" "$TARGET_DIR/boot/grub/grub.cfg"
> > +# Detect boot strategy, EFI or BIOS
> > +if [ -f "$BINARIES_DIR/efi-part/startup.nsh" ]; then
> > +    cp -f "$BOARD_DIR/grub-efi.cfg" "$BINARIES_DIR/efi-part/EFI/BOOT/grub.cfg"
> > +else
> > +    cp -f "$BOARD_DIR/grub-bios.cfg" "$TARGET_DIR/boot/grub/grub.cfg"
> > +
> > +    # Copy grub 1st stage to binaries, required for genimage
> > +    cp -f "$HOST_DIR/lib/grub/i387-pc/boot.img" "$BINARIES_DIR"
> > +fi
> > +
> > +#cp -f "$BOARD_DIR/grub-bios.cfg" "$TARGET_DIR/boot/grub/grub.cfg"
>
> Do we need to keep this commented line ?
>
> >
> >  # Copy grub 1st stage to binaries, required for genimage
> > -cp -f "$HOST_DIR/lib/grub/i386-pc/boot.img" "$BINARIES_DIR"
> > +#cp -f "$HOST_DIR/lib/grub/i386-pc/boot.img" "$BINARIES_DIR"
>
> Here as well, and the comment above ?
>
> Note: no need to respin just for this, I can fixup when applying, just
> let me know.
>
> Thanks!
>
> Thomas

The comments can be removed.

-- 
Carlos Santos <unixmania at gmail.com>