[Buildroot] [PATCH 14/18] checkpackagelib/lib_config.py: CommentsMenusPackagesOrder: check the order of comments menu
Ricardo Martincoski
ricardo.martincoski at gmail.com
Wed Sep 25 02:14:55 UTC 2019
Hello,
On Tue, Sep 03, 2019 at 06:13 PM, Jerzy Grzegorek wrote:
[snip]
> +++ b/utils/checkpackagelib/lib_config.py
> @@ -61,6 +61,10 @@ class AttributesOrder(_CheckFunction):
>
>
> class CommentsMenusPackagesOrder(_CheckFunction):
> + comment = [""]
> + comments_order_checking = [False]
> + print_comment_warning = [True]
This is not good. Please use instance variables initialized in before().
See my comment on the next patch.
Regards,
Ricardo
More information about the buildroot
mailing list